Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract validation & Playbook.tx_to_json #1176

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

bchamagne
Copy link
Contributor

Description

2 bugfixes while working on playground:

  1. Contract validation was wrong resulting in the possibility to overwrite a contract
  2. Encode16 the content when calling the API

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested while working on the playground

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

fix tx_to_json, now encodes content as expected
@bchamagne bchamagne added the bug Something isn't working label Jul 18, 2023
@bchamagne bchamagne added this to the 1.2.5 milestone Jul 18, 2023
@Neylix Neylix added the mining Involve transaction validation and mining label Jul 18, 2023
@Neylix Neylix merged commit 9cbcaaf into archethic-foundation:develop Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants