Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geo patch as default network patch #1145

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 3, 2023

Description

There is some possibilities that the network patch in a beacon summary aggregate is nil.
In that case, when doing the self repair, we add a default network patch with the node geo patch

Fixes #1136

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test

Also add logs in function update_p2p_availabilities when running a single node (it create an aggregate with empty network patch list

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Jul 3, 2023
@Neylix Neylix added this to the 1.2.4 milestone Jul 3, 2023
@Neylix Neylix linked an issue Jul 3, 2023 that may be closed by this pull request
@samuelmanzanera samuelmanzanera merged commit e06e9a6 into archethic-foundation:release/1.2.4 Jul 4, 2023
@Neylix Neylix deleted the Fix-nil-network-patch branch July 5, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

Bug: update_node_network_patch with nil
3 participants