Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stats serialization #1130

Conversation

bchamagne
Copy link
Contributor

Description

Serialize nb_transaction & burned_fees on 64 bits instead of 32 bits.
Fixes #1059

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested with data from mainnet
  • Tested with hotreload after a benchmark

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working DB Involve database labels Jun 29, 2023
@bchamagne bchamagne added this to the 1.3.0 milestone Jun 29, 2023
@Neylix
Copy link
Member

Neylix commented Jun 29, 2023

I think this fix could be added in 1.2.2 milestone, since this bug could make transaction mint reward refused with consensus error if a node restart between self repair and mint reward time

@samuelmanzanera samuelmanzanera modified the milestones: 1.3.0, 1.2.2 Jun 29, 2023
@samuelmanzanera samuelmanzanera changed the base branch from develop to release/1.2.2 June 29, 2023 10:58
@samuelmanzanera
Copy link
Member

@bchamagne can you change then the migration file to match 1.2.2 ?

@bchamagne bchamagne force-pushed the 1059-statsinfo-serialization branch from a5fbd77 to 1c37e50 Compare June 29, 2023 12:19
@bchamagne bchamagne merged commit ddc5759 into archethic-foundation:release/1.2.2 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DB Involve database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats file does not store well the burned fees amount
3 participants