Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart Contracts: Allow a contract without trigger:transaction to receive calls #1124

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Smart Contracts: Allow a contract without trigger:transaction to receive calls #1124

merged 2 commits into from
Jun 28, 2023
+49 −4

Conversation

bchamagne
Copy link
Contributor

Description

Due to the verification of the recipients introduced in v1.2, it is now impossible to send calls to a contract that does not have a trigger transaction. This PR change the logic to: A contract must have a condition transaction to receive a call.

Type of change

  • Regression

How Has This Been Tested?

Unit tested & tested with playbook "Faucet"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working smart contracts Involve smart contracts labels Jun 27, 2023
@bchamagne bchamagne added this to the 1.2.1 milestone Jun 27, 2023
@bchamagne bchamagne mentioned this pull request Jun 27, 2023
Merged
@bchamagne bchamagne modified the milestones: 1.2.1, 1.2.2 Jun 27, 2023
@bchamagne bchamagne changed the base branch from develop to release/1.2.2 June 28, 2023 09:32
@samuelmanzanera samuelmanzanera merged commit ff9e6b0 into archethic-foundation:release/1.2.2 Jun 28, 2023
samuelmanzanera pushed a commit that referenced this pull request Jul 5, 2023
@bchamagne @samuelmanzanera
Smart Contracts: Allow a contract without trigger:transaction to rece…
0af81c7 
…ive calls (#1124)

* Allow a contract without trigger:transaction to receive calls

* Do not force the 'condition transaction' to be able to remove calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neylix Neylix Neylix approved these changes

Assignees
No one assigned
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bchamagne @Neylix @samuelmanzanera