Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appup transform to restart telemetry #1116

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jun 21, 2023

Description

When we update the telemetry metrics, we need to restart the telemetry process to update metrics with the updated ones.

To solve this I added an appup transform to restart the prometheus metrics started by supervisor Archethic.Telemetry

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Update project version, create a new appup with mix distillery.gen.appup --app archethic
instructions are just before the migration script

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added the release Involve release / hot reload mecanism label Jun 21, 2023
@samuelmanzanera samuelmanzanera merged commit bb6fbcb into archethic-foundation:develop Jun 21, 2023
@Neylix Neylix deleted the Add-telemetry-transform branch June 22, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements release Involve release / hot reload mecanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants