Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill 2 previous daily nonce on boostrap #1043

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented May 17, 2023

Description

Fixes an issue happening when an authorized node restart between a node_shared_secret transaction and it's application date (between xx:xx:40 and xx:xx:00 on dev / 23:55:00 and 00:00:00 on prod)
The implementation was filling the ets table with only the last node shared secret transaction, so after the node restart it cannot retrieve the daily nonce for the current day as it only filled the one of the next day

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Restart a node after a node shared secret and ask for a faucet, the transaction is now validated without error

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working bootstrap labels May 17, 2023
@Neylix Neylix requested a review from samuelmanzanera May 17, 2023 11:31
@Neylix Neylix merged commit 5bbdad4 into archethic-foundation:1.1.0 May 17, 2023
@Neylix Neylix deleted the Fix-daily-nonce-not-loaded branch May 17, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant