Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contracts: Make the 'condition inherit' block mandatory #1009

Merged
merged 3 commits into from
May 4, 2023

Conversation

bchamagne
Copy link
Contributor

Description

The condition inherit always were mandatory, but there was a bug in the code.
This resulted in the ability to create smart contracts without the block but the contracts were unable to produce any next_tx because they would all fail the inherit constraints. (empty condition inherit block ==> refusing all transactions).

ps: the condition inherit block will become optional in a later release.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual test
Screenshot_2023-05-03_18-17-35

  • Unit test added

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working smart contracts Involve smart contracts labels May 3, 2023
@bchamagne bchamagne added this to the v.1.0.8-rc2 milestone May 3, 2023
@Neylix Neylix force-pushed the sc-mandatory-inherit branch from f1ba97b to 8cfb89d Compare May 4, 2023 08:43
@bchamagne bchamagne force-pushed the sc-mandatory-inherit branch from 8cfb89d to d9ee434 Compare May 4, 2023 12:15
@Neylix Neylix force-pushed the sc-mandatory-inherit branch from d9ee434 to 0f1207e Compare May 4, 2023 13:06
@bchamagne bchamagne force-pushed the sc-mandatory-inherit branch from 0f1207e to fd7c841 Compare May 4, 2023 13:13
@Neylix Neylix merged commit d01bb0b into archethic-foundation:develop May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants