Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p2p view upgrade #1002

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented May 2, 2023

Description

This PR adds a function code_change in the P2PView genserver to update the backup file with the new serialization

Also fix the backward compatibility when deserializing SummaryCache backup file

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Create a release from master branch
  • Switch to this PR branch and create a new release
  • Apply the release at the beginning of a summary
  • Stop the node and restart it, it should restart without error with the good P2P view and with the summary cache filled with all slots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working release Involve release / hot reload mecanism labels May 2, 2023
@samuelmanzanera samuelmanzanera added this to the v.1.0.8-rc2 milestone May 3, 2023
@Neylix Neylix merged commit 7ca4567 into archethic-foundation:develop May 4, 2023
@Neylix Neylix deleted the Fix-P2PView-upgrade branch May 4, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Involve release / hot reload mecanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants