Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch UCO price from CoinMarketCap #729

Closed
Neylix opened this issue Nov 30, 2022 · 0 comments
Closed

Fetch UCO price from CoinMarketCap #729

Neylix opened this issue Nov 30, 2022 · 0 comments
Assignees
@tenmoves
Labels
feature New feature request oracle chain Involve OracleChain

Comments

@Neylix
Copy link
Member

Neylix commented Nov 30, 2022

Is your feature request related to a problem?

As #727 will permit to have multiple data source for an oracle value, we should get the uco price from other source.

Describe the solution you'd like

CoinMarketCap do not explose a free API to get currency price. But we can parse the HTML page containing the UCO price.
https://coinmarketcap.com/currencies/uniris/markets/
On this page there is multiple price information, one global and one per exchange. We could get all there price information and add them into the aggregator

Additional context

For HTML parsing we can use Floki : https://hexdocs.pm/floki/Floki.html
@Neylix Neylix added feature New feature request oracle chain Involve OracleChain labels Nov 30, 2022
@tenmoves tenmoves self-assigned this Dec 9, 2022
@tenmoves tenmoves mentioned this issue Dec 13, 2022
Closed
netboz added a commit to netboz/archethic-node that referenced this issue Dec 13, 2022
@netboz
Refactor to integrate with archethic-foundation#728 and archethic-fou…
b8fb55a 
…ndation#729 wip
netboz added a commit to netboz/archethic-node that referenced this issue Jan 6, 2023
@netboz
Refactor to integrate with archethic-foundation#728 and archethic-fou…
8cd5ee1 
…ndation#729 wip
Neylix added a commit that referenced this issue Jan 11, 2023
@netboz @tenmoves @Neylix
Pr 727 create oracle services data agregator (#769)
7354d91 
* Update UCO service provider to list of providers #727
[Config Change]

* Updating UCO service to compute mean of provider results #727

* Updating tests #727

* Formatting #727

* Removing unneeded duplicate service #727

* refactor services prices fetching

* formatting code #727

* Refactor to integrate with #728 and #729 wip

* Fixing tests and formatting

* Adding tests for error cases, formatting

* Parallelize service values fetching

* Linting

* Fixing test after mock renaming

* Adding general failsafe clause

* add coin marketcap and coin paprika as uco price providers

* Integrating #769

* Fixing legacy tests

* Fixing tests

* Adding option to kill task on timeout

* Increase log severity when no data returned by service

* Slight optimisation

* Compute median instead of mean

* transform prices from keyword list to map in coingecko

* Make service result parsing more resilient

* lowercasing key for code resilience

* Fixing index issue

* Fixing flaky test

* Unlink fetching processes to avoid termination of scheduler if service crash

* updated coin marketcap and coin paprika

* updated marketcap implementation

* Refactoring median function

* Refactoring Agregator, adapting tests accordingly.

* Reducing max nesting level to please credo plus format big numbers

* Fix remaining bugs

Co-authored-by: tenmoves <hamza.belhaj07@gmail.com>
Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenmoves tenmoves

Labels
feature New feature request oracle chain Involve OracleChain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tenmoves @Neylix @internet-zero