Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for the node's IP address #108

Closed
ghost opened this issue Oct 6, 2021 · 5 comments · Fixed by #123
Closed

Add validation for the node's IP address #108

ghost opened this issue Oct 6, 2021 · 5 comments · Fixed by #123
Assignees
@roychowdhuryrohit-dev
Labels
bug Something isn't working P2P Involve P2P networking

Comments

@ghost
Copy link

ghost commented Oct 6, 2021 •
edited by samuelmanzanera
Loading

Prevents unreachable or dummy node's IP address to join (i.e 0.0.0.0, 127.0.0.1, etc.)
Prevents an already existing IP address to join (to avoid conflicts)

Epic: #306
@ghost ghost added bug Something isn't working P2P Involve P2P networking labels Oct 6, 2021
@ghost ghost added this to the 1.0 milestone Oct 6, 2021
@ghost
Copy link
Author

ghost commented Oct 7, 2021

I think we also need to may to bypass the verification , for instance during dev, loopback address should be allowed or even private ones (for docker)

@ghost
Copy link
Author

ghost commented Oct 7, 2021

we can also exclude router addresses

@roychowdhuryrohit-dev
Copy link
Contributor

Yes we will filter out all the private address ranges.
https://www.ibm.com/docs/en/networkmanager/4.2.0?topic=translation-private-address-ranges

@roychowdhuryrohit-dev
Copy link
Contributor

So I am only implementing this for prod because in dev I use 0.0.0.0.

@internet-zero internet-zero modified the milestone: 1.0 Oct 19, 2021
@roychowdhuryrohit-dev
Copy link
Contributor

Writing testcases for p2p.ex, pending_transaction_validation.ex, networking.ex.

@ghost ghost linked a pull request Oct 29, 2021 that will close this issue
Add node IP validation in prod #123
Merged
@ghost ghost closed this as completed in #123 Nov 4, 2021
ghost pushed a commit that referenced this issue Nov 4, 2021
Add node connection validation
0a22d05 
Added IP address verification to ensure a node is reachable (discarding private IP ranges, and unreachable addresses)
Added node duplication check to avoid overload of IP/Port for different nodes

Fixes #108
@ghost ghost mentioned this issue May 13, 2022
Open
@ghost ghost mentioned this issue Jun 27, 2022
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roychowdhuryrohit-dev roychowdhuryrohit-dev

Labels
bug Something isn't working P2P Involve P2P networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add node IP validation in prod
2 participants
@roychowdhuryrohit-dev @internet-zero