Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide exception when getCurrentAccount RPC fails. #18

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Do not hide exception when getCurrentAccount RPC fails. #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions lib/src/util/transaction_util.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:async';
import 'dart:developer' as dev;

import 'package:archethic_dapp_framework_flutter/src/domain/models/failures.dart';
import 'package:archethic_dapp_framework_flutter/src/util/custom_logs.dart';
import 'package:archethic_dapp_framework_flutter/src/util/generic/get_it_instance.dart';
Expand Down Expand Up @@ -191,16 +192,11 @@ mixin TransactionMixin {

// TODO(a): remove the try catch, not mandatory but I added it to have the connection issue front exception for the user
try {
final result =
await sl.get<awc.ArchethicDAppClient>().getCurrentAccount();
result.when(
failure: (failure) {
throw Exception('An error occurs');
},
success: (result) {
accountName = result.shortName;
},
);
final result = await sl
.get<awc.ArchethicDAppClient>()
.getCurrentAccount()
.valueOrThrow;
accountName = result.shortName;
} catch (e, stackTrace) {
sl.get<LogManager>().log(
'$e',
Expand Down