-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle complex website #61
Conversation
Here you can find the site I used to test. (I removed the white paper pdf because size was to big for Github) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, It will be nice to open links to external links such as https ou ipfs, such as This is more flexible, not sure that we will store everything in ArchEthic and apps like I am développer will be able to implement different statregies. It will be also a big limitation if we point to a transaction only on a content et not to another JSON description as children. For exemple, one transaction can contain a lib with js & css, (shared by other site) called from another transaction containing the website. Valette P |
Hi ! Thanks for your contribution :) I don't really understand when you will use this because let's say you want to use the script from another transaction, in your html file you can directly use the url like: <script src="archethic://000123456789"></script>
<img src="ipfs://xxxxxxxxxx" /> And so the browser will directly request for the good url |
This PR is the first implementation to solve the issue #60
Actually the CLI do:
This has been tested with actual archethic.net site and with wallet site.
But the problem is that both sites have a bigger size than the maximum content size allowed in a transaction, even after compression.
So the next step will be to reduce content of a transaction to 3.5 MB max.
We can split content in different transactions and refer the transaction address in the JSON object :
And so the node API will get the content of this file inside the transaction at "address".
But for files above 3.5 MB we need to split the file, maybe by using esbuild for example.