Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding waitConfirmations function #48

Merged
5 commits merged into from
Mar 24, 2022
Merged

Adding waitConfirmations function #48

5 commits merged into from
Mar 24, 2022

Conversation

manujuniris
Copy link
Contributor

Added waitConfirmations function from libjs

@manujuniris manujuniris requested a review from a user March 18, 2022 07:17
@manujuniris manujuniris self-assigned this Mar 18, 2022
@manujuniris manujuniris added the feature new feature or enhancement label Mar 18, 2022
@manujuniris manujuniris requested a review from blackode March 21, 2022 09:18
ghost
ghost reviewed Mar 22, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the success message should be displayed when the transaction is confirmed and not before. Otherwise this will be a misleading for the user.

@manujuniris
Copy link
Contributor Author

I think the success message should be displayed when the transaction is confirmed and not before. Otherwise this will be a misleading for the user.

fixed

@ghost
Copy link

ghost commented Mar 23, 2022 •
edited by ghost
Loading

I think the success message should be displayed when the transaction is confirmed and not before. Otherwise this will be a misleading for the user.

fixed

Ok but the thing, if you have multiple replications, the message will be logged multiple times.
Can be the SLA of the app to be, at least 1 replications before to write the message ?

@manujuniris
Copy link
Contributor Author

I think the success message should be displayed when the transaction is confirmed and not before. Otherwise this will be a misleading for the user.

fixed

Ok but the thing, if you have multiple replications, the message will be logged multiple times. Can be the SLA of the app to be, at least 1 replications before to write the message ?

Done

@ghost ghost added the core team Contribution by core team label Mar 24, 2022
@ghost ghost merged commit b8fc90e into archethic-foundation:main Mar 24, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackode blackode Awaiting requested review from blackode

Assignees

@manujuniris manujuniris

Labels
core team Contribution by core team feature new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manujuniris