Moved decoders to separate module so they can be used externally #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0496265 to
f98fb7a
Compare
AlexeyRaga
reviewed
Mar 28, 2019
| a <- G.getWord32be | ||
| b <- G.getWord32be | ||
| c <- G.getWord32be | ||
| d <- G.getWord32be |
There was a problem hiding this comment.
Other cases use getWord32le, are you use getWord32be here deliberately?
There was a problem hiding this comment.
It's deliberate in the sense that Dave said they did it deliberately.
There was a problem hiding this comment.
Probably because IPv6 is stored in Network Order, which is the same as BE.
There was a problem hiding this comment.
It's interesting though that we store IPv4 in LE, so there is some inconsistency there.
- Added IP Block dumps - Use refactored decoders for complex types - Change catch-all case so we can't miss this in future - Reduced indentation
f98fb7a to
0e4e614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.