Write lookup segments #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67588d5 to
a768469
Compare
newhoggy
reviewed
Mar 27, 2019
| ] | ||
|
|
||
| updateMap k c m = | ||
| maybe (c, c+1, Map.insert k c m) (, c, m) (Map.lookup k m) |
There was a problem hiding this comment.
More type signatures please 😁
There was a problem hiding this comment.
What do you mean? Adding type signature for updateMap in where?
Do you think that (Num a, Ord k) => k -> a -> Map.Map k a -> (a, a, Map.Map k a) would help? :)
There was a problem hiding this comment.
Something like that. Although consider using type variables from lookupSegment with scoped type variables.
dsturnbull
reviewed
Mar 27, 2019
src/Arbor/File/Format/Asif/Write.hs
Outdated
| word16LookupSegment name f = lookupSegment name f (Known F.Word16LE) BB.word16LE | ||
|
|
||
| -- | Creates a lookup segment where index keys are 'Word32' | ||
| -- Missing values are represented by 'maxValue :: Word32' |
There was a problem hiding this comment.
This should be maxBound I think
|
👍 |
a768469 to
2f05bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.