-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify loading of Standard Morphology Files. #2218
Unify loading of Standard Morphology Files. #2218
Conversation
python/label_dict.hpp
Outdated
void import(const label_dict_proxy& other, std::string prefix = "") { | ||
dict.import(other.dict, prefix); | ||
|
||
auto extend(const label_dict_proxy& other, std::string prefix = "") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy of *this
intended when returning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
All morphology loaders now return a
loaded_morphology
object comprisingmorphology
: the morphology corresponding to the data on disksegment_tree
: the raw segment treelabel_dict
: all labels defined in the fileasc
/swc
:axon
,soma
,dend
, andapic
based on tag 1, 2, 3, 4.nml
: the union of the label dicts contained in the metadata, prefixed bygrp:
,nmd:
, andseg:
.metadata
: a set of items given by the fileformatswc
: nothingasc
: a list of spines and marker setsnml
:named_segments
a label dictsegment_groups
a label dictname
-> segment idsgroup_segments
a map from segment id to group name(s)segments
a label dict, one entry per idcell_id
id of the cell defining this morphology, if anyid
id of the morphologyNote that loading neuroml still goes via the
neuroml
object and thecell_morphology
/morphology
accessors return an optional
loaded_morphology
.load_*_raw
functions, asloaded_morphology
bundles the segment tree.load_*
now has an extra indirection.neuroml
changed.label_dict::import
is now calledextend
for future safety (=C++ modules) and Python; calling thingsimport
(=a keyword) is not well received byblack
et al.Issues
Closes #1981