Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Python to known version for all CI workflows #2058

Merged
merged 8 commits into from
Dec 12, 2022

Conversation

brenthuisman
Copy link
Contributor

thorstenhater
thorstenhater previously approved these changes Dec 7, 2022
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for me, but you add two workflow runs. CI is still taking time and costing someone. Do we really need that bit extra?

@brenthuisman
Copy link
Contributor Author

brenthuisman commented Dec 7, 2022

This is a draft PR needed for triggering the workflows, and I'm still investigating the cause of the problem. An important clue is the fact that ubuntu-latest resolves two either of two OSes since early november. Therefore, I want to test both to determine if we can repeat the failure and point to the OS-image as factor. Naturally, the build should succeed on both. I can't tell yet what the reason might be for failing on ubuntu-22.04, but then this must be fixed.

Update:

@brenthuisman
Copy link
Contributor Author

Update: Github have a bit of GCC 12 missing in their image, thanks @schmitts: actions/runner-images#6724

Meanwhile we can stick to 20.04 for Spack workflows.

@brenthuisman brenthuisman marked this pull request as ready for review December 8, 2022 15:53
Copy link
Contributor

@schmitts schmitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llandsmeer llandsmeer merged commit 27db9a7 into arbor-sim:master Dec 12, 2022
llandsmeer pushed a commit that referenced this pull request Dec 15, 2022
* Python Wheel workflow uses `ubuntu-20.04` to fix the build
  * In #2058 I forgot to update `ciwheel.yml`
* Why this is necessarily: still have not figured it out. `cibuildwheel`
builds and tests in it's own container...
  * [x] https://github.com/brenthuisman/arbor/actions/runs/3704419712
* Small change to make `musllinux` wheels build. They don't pass testing
yet, so I don't add them to the workflow but that can be solved/added
[later](pypa/cibuildwheel#1376)
* The reason for using `ubuntu-20.04` in the Spack workflow should [no
longer exist](actions/runner-images#6724).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants