Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/test individual pod deletion #72

Merged
merged 10 commits into from
Mar 26, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 26, 2018

No description provided.

@ewoutp ewoutp added the 9 WIP label Mar 26, 2018
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See one question.

// Tests handling of individual pod deletions
func TestResiliencePod(t *testing.T) {
longOrSkip(t)
c := client.MustNewInCluster()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This panics in case of failure, is this the right behaviour? Should we not rather hand in the *testing.T and call Fatalf in that case?

@ewoutp ewoutp removed the 9 WIP label Mar 26, 2018
@ewoutp ewoutp merged commit e0329ea into master Mar 26, 2018
@ewoutp ewoutp deleted the feature/test-individual-pod-deletion branch March 26, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants