Compatibility with Web3.js patching the ethereum provider #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c28c9b5 to
d3526e6
Compare
sohkai
approved these changes
Feb 17, 2020
| @@ -10,30 +10,53 @@ export function getNetworkName(chainId) { | |||
|
|
|||
| export function rpcResult(response) { | |||
| // Some providers don’t wrap the response | |||
| if (response && response.jsonrpc) { | |||
| if (response && 'jsonrpc' in response) { | |||
There was a problem hiding this comment.
Interesting; usually you'd want to avoid in.
Does a hasOwnProperty() not work, because we're traversing a proxy or etc?
There was a problem hiding this comment.
No I almost used hasOwnProperty(), but then I thought I don’t have a reason to invalidate jsonrpc if it was on the prototype. Do you see one?
There was a problem hiding this comment.
Not particularly, but then wouldn't normal property accessing through the . work?
There was a problem hiding this comment.
No, it’s set to undefined in some cases (MetaMask’s sendAsync()) :-(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added as a question for web3.js at web3/web3.js#3374.