settings: network preferences #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/aragon/court-dashboard/b290ea0rc |
sohkai
reviewed
Apr 2, 2020
|
|
||
| return ( | ||
| <React.Fragment> | ||
| <Box heading="Node settings"> |
There was a problem hiding this comment.
We should add a setting for the subgraph API endpoint (and like the ETH node, do some sanity checks against it to make sure it works).
There was a problem hiding this comment.
just to understand why do we want to let the user change the data source of the dashboard?
There was a problem hiding this comment.
In case they wanted to run their own hosted instance of the subgraph, just like the ETH node or IPFS gateway.
sohkai
reviewed
Apr 6, 2020
sohkai
reviewed
Apr 6, 2020
sohkai
reviewed
Apr 6, 2020
sohkai
reviewed
Apr 6, 2020
sohkai
approved these changes
Apr 8, 2020
sohkai
reviewed
Apr 8, 2020
sohkai
reviewed
Apr 8, 2020
sohkai
reviewed
Apr 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this branch from the court stats one since i needed some stuffs from there, so it will be good to review first #229
Also leaving here a screenshot for further discussions about improvements/changes