PE-5964: App scaffold, Navigation, Sidebar, Routing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kunstmusik
commented
Apr 24, 2024
- Implements app layout, navigation bar, and side bar.
- Does not implement breadcrumbs as it will be implemented as part of gateway story.
… from including transparent- color tokens
…-sider-navbar-routing-breadcrumbs
|
Visit the preview URL for this PR (updated for commit f75682e): https://ar-io-network-portal-a40ee--pr2-pe-5964-navigation-s-2urf5gxt.web.app (expires Thu, 09 May 2024 21:58:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7abfae09c4446982a71cbb94b0cbf4688377a111 |
dtfiedler
reviewed
Apr 24, 2024
dtfiedler
reviewed
Apr 24, 2024
src/layout/Sidebar.tsx
Outdated
Comment on lines
36
to
37
| ? 'flex h-[34px] w-full items-center space-x-[11px] px-[11px] py-[5px] rounded-[6px] bg-gradient-to-b shadow-[0px_0px_0px_1px_#050505,0px_1px_0px_0px_rgba(86,86,86,0.25)_inset] dark:from-[rgba(102,102,102,.06)] dark:to-[rgba(0,0,0,0.06)] dark:bg-[#212124]' | ||
| : 'flex h-[34px] w-full items-center space-x-[11px] px-[11px] py-[5px] hover:rounded-[6px] hover:bg-gradient-to-b hover:shadow-[0px_0px_0px_1px_#050505,0px_1px_0px_0px_rgba(86,86,86,0.25)_inset] dark:from-[rgba(102,102,102,.06)] dark:to-[rgba(0,0,0,0.06)] hover:dark:bg-[#212124]'; |
There was a problem hiding this comment.
can we set some of these rgb and hash colors in our tailwind config and give them friendly names?
There was a problem hiding this comment.
Let me do an audit and see about cleaning these up.
dtfiedler
approved these changes
Apr 24, 2024
fix(ario): use web import for ario/sdk
…nize-imports to work better with tailwind classname sorting
…or secondary route items
atticusofsparta
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.