Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing credentials for downloading the java-db from private registry #2353

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

tom1299
Copy link
Contributor

@tom1299 tom1299 commented Dec 9, 2024

Description

The main container with the image command of a scan job fails when pulling the java-db from a private registry because of missing credentials. This PR introduces a second init container analogous to the one that downloads the trivy-db but downloads the java-db if it is to be pulled from a private registry.
This results in the main container not having to download the java-db since it is up to date.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@tom1299
Copy link
Contributor Author

tom1299 commented Dec 9, 2024

Please note that I added an dedicated test case for this case instead of adding an additional on to the main test cases in TestPlugin_GetScanJobSpec because I thought that a test case focusing only on the actual functionality seemed easier to understand. But I can move the test to TestPlugin_GetScanJobSpec if that fits better

@tom1299 tom1299 changed the title Fix missing credentials for java-db from private registry fix: Missing credentials for downloading the java-db from private registry Dec 9, 2024
@github-actions github-actions bot added the bug label Dec 9, 2024
@tom1299 tom1299 marked this pull request as ready for review December 10, 2024 05:31
@afdesk afdesk added this to the v0.24.0 milestone Dec 11, 2024
@afdesk afdesk requested review from simar7 and afdesk January 9, 2025 13:01
@afdesk
Copy link
Contributor

afdesk commented Jan 9, 2025

@tom1299 thanks for the contribution!

@afdesk
Copy link
Contributor

afdesk commented Jan 9, 2025

@simar7 could you take a look please?

@simar7
Copy link
Member

simar7 commented Jan 9, 2025

nice, thanks @tom1299 for your contribution!

@simar7 simar7 merged commit 35e0c4d into aquasecurity:main Jan 9, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants