Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

chore: Downgrade Go from 1.15 to 1.14 #144

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Dec 11, 2020

Harbor 2.2 is still built with Go 1.14 because of the breaking change in Go 1.15.

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #144 (1495ee0) into master (6659785) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   69.36%   69.36%           
=======================================
  Files          12       12           
  Lines         581      581           
=======================================
  Hits          403      403           
  Misses        154      154           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6659785...1495ee0. Read the comment docs.

Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine, though it's a shame we have to do it

@danielpacak danielpacak merged commit d0f7e86 into master Dec 11, 2020
@danielpacak danielpacak deleted the downgrade_go_to_v1.14 branch December 11, 2020 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants