fix: improve the completion settings suggested in aqua completion --help

[akinomyoga]

Check List

• Read CONTRIBUTING.md
  • Read OSS Contribution Guide
• Write a GitHub Issue before creating a Pull Request
  • Link to the issue: Improvements on the example configuration for completion in Bash #3294
• All commits are signed
  • This repository enables Require signed commits, so all commits must be signed
• Avoid force push
• Do only one thing in one Pull Request

Three fixes are included in this PR.

(1) .bashrc and .zshrc 4e21f1d

The current help text suggests adding the completion settings in .bash_profile and .zprofile, but .bash_profile and .zprofile are loaded only in login shell sessions. They are not loaded in (non-login) interactive sessions started inside the login shells, and thus the completion would be disabled in non-login interactive sessions.

Actual

$ cat .bash_profile
if command -v aqua &> /dev/null; then
  source <(aqua completion bash)
fi
$ bash
$ complete -p aqua
<nothing is output>

Expected

$ cat .bashrc
if command -v aqua &> /dev/null; then
  source <(aqua completion bash)
fi
$ bash
$ complete -p aqua
complete -o bashdefault -o default -o nospace -F _cli_bash_autocomplete aqua

In general, .bash_profile and .zprofile should only contain the settings that are automatically inherited by the child processes or the global user settings in the operating system. The interactive settings should be put in .bashrc and .zshrc.

In this commit, we suggest .bashrc and .zshrc instead of .bash_profile and .zprofile, respectively.

(2) Fix for Bash 3.* 8cbabba

The currently suggested setting does not work for Bash 3.* because the source builtin in Bash 3.* does not support reading from a pipe and source <(command) fails silently. Instead, eval "$(command)" works in all versions of Bash.

Actual

$ bash-3.2
$ source <(aqua completion bash)
$ complete -p aqua
<nothing is output>

Expected

$ bash-3.2
$ eval "$(aqua completion bash)"
$ complete -p aqua
complete -o bashdefault -o default -o nospace -F _cli_bash_autocomplete aqua

(3) Style improvement 64ad3b4

This is an appearance improvement for the examples of different shells, and the change is just as you see in the diff.

[suzuki-shunsuke]

Thank you for your contribution!

[suzuki-shunsuke]

🎉 https://github.com/aquaproj/aqua/releases/tag/v2.38.1