Allow to specify sentry envionment and release. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I can see, the tests failed due to a dependency in the Go standard library. They can be fixed by upgrading the Go version. However, I'm not sure if such changes should be made by me or implemented in the current PR. Can someone clarify what guidelines exist regarding this? |
aaw
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Hey @imperiuse, thanks for the PR! Two things before merging:
- Can you merge in recent changes to master? I fixed the govulnreport build failure you've already noticed by upgrading the go version, that should make your build green.
- Can you update the README? There's a section describing the Sentry config already that should be updated with this PR.
Thanks!
fix. after review
4cc3673 to
e475129
Compare
done. |
Thank you for the review. Should I do anything else, or should I wait for the project maintainers? |
|
@imperiuse I just merged this PR and released it as v0.2.28. |
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly
Dec 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aptible/supercronic](https://togithub.com/aptible/supercronic) | patch | `v0.2.27` -> `v0.2.28` | --- ### Release Notes <details> <summary>aptible/supercronic (aptible/supercronic)</summary> ### [`v0.2.28`](https://togithub.com/aptible/supercronic/releases/tag/v0.2.28) [Compare Source](https://togithub.com/aptible/supercronic/compare/v0.2.27...v0.2.28) #### What's Changed - Update Go to 1.21.4 by [@​aaw](https://togithub.com/aaw) in [https://github.com/aptible/supercronic/pull/141](https://togithub.com/aptible/supercronic/pull/141) - Allow to specify sentry envionment and release. by [@​imperiuse](https://togithub.com/imperiuse) in [https://github.com/aptible/supercronic/pull/140](https://togithub.com/aptible/supercronic/pull/140) #### New Contributors - [@​aaw](https://togithub.com/aaw) made their first contribution in [https://github.com/aptible/supercronic/pull/141](https://togithub.com/aptible/supercronic/pull/141) - [@​imperiuse](https://togithub.com/imperiuse) made their first contribution in [https://github.com/aptible/supercronic/pull/140](https://togithub.com/aptible/supercronic/pull/140) **Full Changelog**: aptible/supercronic@v0.2.27...v0.2.28 ### Installation Instructions #### supercronic-linux-amd64 Add the following stanza to your Dockerfile to install `supercronic-linux-amd64`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-amd64 \ SUPERCRONIC=supercronic-linux-amd64 \ SUPERCRONIC_SHA1SUM=fe1a81a8a5809deebebbd7a209a3b97e542e2bcd RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic #### supercronic-linux-386 Add the following stanza to your Dockerfile to install `supercronic-linux-386`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-386 \ SUPERCRONIC=supercronic-linux-386 \ SUPERCRONIC_SHA1SUM=6a37b4365698a0f83dc52ebcbad66a4ed1576369 RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic #### supercronic-linux-arm Add the following stanza to your Dockerfile to install `supercronic-linux-arm`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-arm \ SUPERCRONIC=supercronic-linux-arm \ SUPERCRONIC_SHA1SUM=57cf7d4f0b85255bc45150ff6603358ffdfc3a00 RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic #### supercronic-linux-arm64 Add the following stanza to your Dockerfile to install `supercronic-linux-arm64`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-arm64 \ SUPERCRONIC=supercronic-linux-arm64 \ SUPERCRONIC_SHA1SUM=6f2247cb06a0845e3e4ae1b5c95e4d0ed0dcfedd RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly-template
Dec 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aptible/supercronic](https://togithub.com/aptible/supercronic) | patch | `v0.2.27` -> `v0.2.28` | --- ### Release Notes <details> <summary>aptible/supercronic (aptible/supercronic)</summary> ### [`v0.2.28`](https://togithub.com/aptible/supercronic/releases/tag/v0.2.28) [Compare Source](https://togithub.com/aptible/supercronic/compare/v0.2.27...v0.2.28) #### What's Changed - Update Go to 1.21.4 by [@​aaw](https://togithub.com/aaw) in [https://github.com/aptible/supercronic/pull/141](https://togithub.com/aptible/supercronic/pull/141) - Allow to specify sentry envionment and release. by [@​imperiuse](https://togithub.com/imperiuse) in [https://github.com/aptible/supercronic/pull/140](https://togithub.com/aptible/supercronic/pull/140) #### New Contributors - [@​aaw](https://togithub.com/aaw) made their first contribution in [https://github.com/aptible/supercronic/pull/141](https://togithub.com/aptible/supercronic/pull/141) - [@​imperiuse](https://togithub.com/imperiuse) made their first contribution in [https://github.com/aptible/supercronic/pull/140](https://togithub.com/aptible/supercronic/pull/140) **Full Changelog**: aptible/supercronic@v0.2.27...v0.2.28 ### Installation Instructions #### supercronic-linux-amd64 Add the following stanza to your Dockerfile to install `supercronic-linux-amd64`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-amd64 \ SUPERCRONIC=supercronic-linux-amd64 \ SUPERCRONIC_SHA1SUM=fe1a81a8a5809deebebbd7a209a3b97e542e2bcd RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic #### supercronic-linux-386 Add the following stanza to your Dockerfile to install `supercronic-linux-386`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-386 \ SUPERCRONIC=supercronic-linux-386 \ SUPERCRONIC_SHA1SUM=6a37b4365698a0f83dc52ebcbad66a4ed1576369 RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic #### supercronic-linux-arm Add the following stanza to your Dockerfile to install `supercronic-linux-arm`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-arm \ SUPERCRONIC=supercronic-linux-arm \ SUPERCRONIC_SHA1SUM=57cf7d4f0b85255bc45150ff6603358ffdfc3a00 RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic #### supercronic-linux-arm64 Add the following stanza to your Dockerfile to install `supercronic-linux-arm64`. You will need to install `curl` beforehand. ### Latest releases available at https://github.com/aptible/supercronic/releases ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.28/supercronic-linux-arm64 \ SUPERCRONIC=supercronic-linux-arm64 \ SUPERCRONIC_SHA1SUM=6f2247cb06a0845e3e4ae1b5c95e4d0ed0dcfedd RUN curl -fsSLO "$SUPERCRONIC_URL" \ && echo "${SUPERCRONIC_SHA1SUM} ${SUPERCRONIC}" | sha1sum -c - \ && chmod +x "$SUPERCRONIC" \ && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \ && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
PR for this issue -> #114