Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar footer --> go to console button (mobile view) #211

Closed
wants to merge 2 commits into from

Conversation

goswamianshuman
Copy link

What does this PR do?

Fixed the go-to console link at the footer in the sidebar when we are in mobile view.

Test Plan

I replaced the button with a link tag which redirects to the console.

image

Related PRs and Issues

checkout pr: #176

Have you read the Contributing Guidelines on issues?

yes.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 2:50pm

@ArnabBCA
Copy link
Contributor

ArnabBCA commented Oct 8, 2023

What does this PR do?

Fixed the go-to console link at the footer in the sidebar when we are in mobile view.

Test Plan

I replaced the button with a link tag which redirects to the console.

image

Related PRs and Issues

checkout pr: #176

Have you read the Contributing Guidelines on issues?

yes.

Bro that issue is opened by me and I am yet to get it assigned . Pls follow the guidelines you have to open the issue first then create a pull request.

@goswamianshuman
Copy link
Author

goswamianshuman commented Oct 8, 2023

Hey @ArnabBCA I'm really sorry for this thing, actully I'm unable to see that you have marked any message asking for assigning the task to you, so I thought you havn't made any request that's the reason I made a PR.

Screenshot_2023-10-08-21-43-33-72_e2d5b3f32b79de1d45acd1fad96fbb0f.jpg

if you want then I can remove my pull request, again sorry for creating the PR

@ArnabBCA
Copy link
Contributor

ArnabBCA commented Oct 8, 2023

Hey @ArnabBCA I'm really sorry for this thing, actully I'm unable to see that you have marked any message asking for assigning the task to you, so I thought you havn't made any request that's the reason I made a PR.

Screenshot_2023-10-08-21-43-33-72_e2d5b3f32b79de1d45acd1fad96fbb0f.jpg

if you want then I can remove my pull request, again sorry for creating the PR

Screenshot 2023-10-08 222321
See I had already asked to assign it to me.
Even if it was not assigned the guideline is you cannot create a pr without an issue being assigned to someone

Kindly close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants