Fix appsignal_free_* FFI missing pointer arguments #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `appsignal_free_transaction` and `appsignal_free_data` Rust extension function calls were missing their argument definitions in the FFI declaration. These are the function definitions from the `appsignal.h` file, downloaded upon installation. ```c void appsignal_free_transaction(appsignal_transaction_t*); void appsignal_free_data(appsignal_data_t*); ``` Fixes #854 where users saw very high CPU usage because the function call was being retried indefinitely. Co-authored-by: Raimonds Simanovskis <raimonds.simanovskis@gmail.com>
thijsc
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
appsignal_free_transactionandappsignal_free_dataRustextension function calls were missing their argument definitions in the
FFI declaration.
These are the function definitions from the
appsignal.hfile,downloaded upon installation.
Fixes #854 where users saw very high CPU usage because the function call
was being retried indefinitely.
Co-authored-by: Raimonds Simanovskis raimonds.simanovskis@gmail.com