Fix deprecation warning for working_dir_path #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismiramirez
requested changes
Jan 14, 2022
It would only print the warning if the config option was used in the file source, but if the `APPSIGNAL_WORKING_DIR_PATH` environment variable was set, it would not print the same deprecation warning. This only makes the deprecation more visible. This is necessary before we fully remove it in the next major version. I've added a changeset, because it prints the warning in more scenarios and those are scenarios we want to inform our users about before removing the config option entirely. Fixes #805
9202b3f to
38e9429
Compare
luismiramirez
approved these changes
Jan 14, 2022
jeffkreeftmeijer
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would only print the warning if the config option was used in the
file source, but if the
APPSIGNAL_WORKING_DIR_PATHenvironmentvariable was set, it would not print the same deprecation warning. This
only makes the deprecation more visible. This is necessary before we
fully remove it in the next major version.
I've added a changeset, because it prints the warning in more scenarios
and those are scenarios we want to inform our users about before
removing the config option entirely.
Fixes #805
Based on #804