Fix tests on client start #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests would assert the opposite behaviour of that which they claimed to test. The test itself was broken, as it was spying on a previously created client object, then creating a new client object and performing actions on it, [as pointed out by @tombruijn in #612][comment]. This commit fixes the existing tests so they perform the right assertions, and adds a new one for the behaviour implied by the tests. [comment]: #612 (comment)
|
✔️ All good! |
luismiramirez
approved these changes
Feb 14, 2022
tombruijn
approved these changes
Feb 14, 2022
jeffkreeftmeijer
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changeset]
These tests would assert the opposite behaviour of that which they claimed to test. The test itself was broken, as it was spying on a previously created client object, then creating a new client object and performing actions on it, as pointed out by @tombruijn in #612.
This commit fixes the existing tests so they perform the right assertions, and adds a new one for the behaviour implied by the tests.