Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restify instrumentation #787

Closed
6 tasks done
luismiramirez opened this issue Nov 10, 2022 · 2 comments · Fixed by #819
Closed
6 tasks done

Restify instrumentation #787

luismiramirez opened this issue Nov 10, 2022 · 2 comments · Fixed by #819
Assignees
@tombruijn
Labels
enhancement

Comments

@luismiramirez
Copy link
Member

luismiramirez commented Nov 10, 2022 •
edited by tombruijn
Loading

Web framework.

https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-restify

To do

  • Add instrumentation to the client by default
    • Only if the instrumentation library is part of the OpenTelemetry core or auto instrumentation package
  • Add extractor for OpenTelemetry spans
  • Add integration test for spans
  • Add docs
  • Add requestHook config option to restify instrumentation: feat(restify): add requestHook support open-telemetry/opentelemetry-js-contrib#1312
  • Update restify instrumentation with requestHook config option to set request parameters
@luismiramirez luismiramirez mentioned this issue Nov 10, 2022
Closed
@tombruijn tombruijn assigned tombruijn and unassigned tombruijn Nov 23, 2022
tombruijn added a commit that referenced this issue Nov 29, 2022
@tombruijn
Add support for the restify package
ae2ea82 
- Add the OpenTelemetry instrumentation.
- Add a test app.

Requires an extension updates before it will report any data.

Part of #787
@tombruijn tombruijn mentioned this issue Nov 29, 2022
Merged
tombruijn added a commit that referenced this issue Nov 30, 2022
@tombruijn
Add support for the restify package (#807)
8c1bd31 
- Add the OpenTelemetry instrumentation.
- Add a test app.

Requires an extension updates before it will report any data.

Part of #787
@tombruijn tombruijn removed their assignment Dec 5, 2022
@tombruijn
Copy link
Member

Once PR open-telemetry/opentelemetry-js-contrib#1312 has been merged and released anyone can pick up the last point to add the requestHook config option.

@tombruijn
Copy link
Member

Tracking issue/PR for the new OpenTelemetry release with the restify requestHook config option: open-telemetry/opentelemetry-js-contrib#1301

@tombruijn tombruijn self-assigned this Jan 2, 2023
@tombruijn tombruijn mentioned this issue Jan 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track restify request parameters appsignal/appsignal-nodejs
2 participants
@tombruijn @luismiramirez