progress indicator for populate_daily_metrics #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple quality of life improvement. The daily pipeline takes a long time to run, and currently gives no indication of how far along in the process it is. Adding a log message like this means that I can quickly tail the logs and form a ballpark estimate of how much longer it will be running. Eg, if we want to deploy (which we need to stop the pipeline for currently), seeing that it's at 1995 of 2000, I'd be inclined to just wait a few minutes for it to finish rather than stop the pipeline, deploy, and restart it. Similarly, if it's been running for 12 hours and we see that it's only made it 10% of the way through, that would indicate that there's a bug or some issue slowing it down and we need to stop the pipeline and investigate before the next day's pipeline starts running and things get even worse.
johnbaldwin
approved these changes
Jun 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 91.28% 91.29%
=======================================
Files 38 38
Lines 1951 1953 +2
=======================================
+ Hits 1781 1783 +2
Misses 170 170
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple quality of life improvement.
The daily pipeline takes a long time to run, and currently gives no indication of how far along in the process it is.
Adding a log message like this means that I can quickly tail the logs and form a ballpark estimate of how much longer it will be running. Eg, if we want to deploy (which we need to stop the pipeline for currently), seeing that it's at 1995 of 2000, I'd be inclined to just wait a few minutes for it to finish rather than stop the pipeline, deploy, and restart it.
Similarly, if it's been running for 12 hours and we see that it's only made it 10% of the way through, that would indicate that there's a bug or some issue slowing it down and we need to stop the pipeline and investigate before the next day's pipeline starts running and things get even worse.