Initial implementation of Celery support for Figures devsite #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please refer to the README.md file in the devsite directory for instructions * This commit adds a docker compose file with support files to start a RabbitMQ docker container. * Devsite is updaed to support Celery tasks running in this docker container * Conditional support for results backend is implemented, but not working. Currently troubleshooting this * Succesfully tested with running Figures `populate_figures_metrics` Django management command. Figures daily metrics models get created with data * Added a new Django management command in Devsite to do a system check. This runs a "system check" task in `devsite/celery.py`
* Added `django-celery` to devsite and Hawthorn multisite requirements file * Added the Docker commands as Figures Makefile targets * Updated devsite/README.md instructions * Added Celery results support using `django-celery` and the Django devsite database as the backend
c91620e to
c05ef3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 91.29% 91.30% +0.01%
==========================================
Files 38 39 +1
Lines 1953 1956 +3
==========================================
+ Hits 1783 1786 +3
Misses 170 170
Continue to review full report at Codecov.
|
|
@melvinsoft @OmarIthawi Finally wrapped this up. I wanted to get the instructions in |
OmarIthawi
approved these changes
Jun 29, 2020
OmarIthawi
reviewed
Jun 29, 2020
| @@ -0,0 +1,10 @@ | |||
| version: '3.5' | |||
| services: | |||
|
|
|||
There was a problem hiding this comment.
do you plan to add Figures here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the README.md file in the devsite directory for
instructions
RabbitMQ docker container.
container
working. Currently troubleshooting this
populate_figures_metricsDjangomanagement command. Figures daily metrics models get created with data
This runs a "system check" task in
devsite/celery.pyNOTE
Although Figures devsite can now run Figures pipeline tasks asynchronously, there's still some debugging work to do to get the results backend working. So created as a draft PR because