Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty signature added after every certificate saving (#30912) #1286

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

melvinsoft
Copy link

Cherrypicking from upstream

A new behaviour:

  • Empty signature is still added when initially create a certificate;
  • Empty signature isn't added when certificate has at least one signature.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

)

A new behaviour:

- Empty signature is still added when initially create a certificate;
- Empty signature isn't added when certificate has at least one signature.
@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/koa.master
Benchmark conflicts with main 111
Current conflicts 111
Summary Good work! No added conflicts.
Comparing with open-release/lilac.master
Benchmark conflicts with main 253
Current conflicts 253
Summary Good work! No added conflicts.
Comparing with open-release/maple.master
Benchmark conflicts with main 284
Current conflicts 284
Summary Good work! No added conflicts.
Comparing with open-release/nutmeg.master
Benchmark conflicts with main 292
Current conflicts 292
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 290
Current conflicts 290
Summary Good work! No added conflicts.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3153221853

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 49.035%

Totals Coverage Status
Change from base Build 3141507176: 0.0009%
Covered Lines: 110926
Relevant Lines: 226218

💛 - Coveralls

@melvinsoft melvinsoft marked this pull request as ready for review September 29, 2022 21:14
Copy link

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!! thanks

@melvinsoft melvinsoft merged commit 84b4571 into main Oct 3, 2022
@melvinsoft melvinsoft deleted the maxi/cherry-pick-studio-certificate-bugfix branch October 3, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants