Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotate button to Plates. Closes #245. #417

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jackwilliard
Copy link
Contributor

Closes #245. Adds a rotate button to the airport diagrams and approach plates. This button does not appear in Track Up mode.

Each click of the button rotates the diagram 90 degrees clockwise.

Four files are affected within the UI code.

Adds a rotate button to the airport diagrams and approach plates.  This button does not appear in Track Up mode.

Each click of the button rotates the diagram 90 degrees clockwise.

Four files are affected within the UI code.
Adds a rotate button to the airport diagrams and approach plates.  This button does not appear in Track Up mode.

Each click of the button rotates the diagram 90 degrees clockwise.

Four files are affected within the UI code.

Change removes rotation when plate changes.
Adds a rotate button to the airport diagrams and approach plates.  This button does not appear in Track Up mode.

Updated to allow arbitrary rotation of plate to 10 degree alignments while handling the most common case of 90degree rotations.
@apps4av
Copy link
Owner

apps4av commented Dec 24, 2020

10 degree rotation is very confusing.

@apps4av
Copy link
Owner

apps4av commented Dec 24, 2020

To reduce clicks, suggest having a button that shows "rotate"
Pressing that button will change "rotate" to "90"
Pressing that button will change "90" to "180"
Pressing that button will change "180" to "270"
Pressing that button will change "270" to "rotate"
Changing the plate will change any value to "rotate"
"rotate" = 0 degrees

@jackwilliard
Copy link
Contributor Author

Yes, that is how pull request bbbb816 worked. It got kicked back without much explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display airport diagrams North up
2 participants