4.3.4 #636
Merged
4.3.4 #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to disable libdnet check through --without-libdnet. This option is useful to cross-compile tcpreplay to avoid build failures if libdnet is installed on host but not on target, see https://bugs.buildroot.org/show_bug.cgi?id=12096 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Depending on compilaiton flags, UNUSED() was declaring variables with different names. Meaning the following can be either expanded to: UNUSED(var) -> var UNUSED(var) -> UNUSED_var __attribute__((unused)) depending on the compilation flags. The code using such a variable would need to also be conditional to the same compilation flags ... and that's to heavy. Let's declare variables by the name they are given instead. UNUSED(var) -> var /* with/without the attribute, but always "var" */ Fixes #612 Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
There is a small typo in libopts/autoopts/options.h, libopts/configfile.c, libopts/restore.c. Should read `hierarchically` rather than `hierarcicaly`.
Prior to this change, time between packets was calculated as deltas and over time errors would quickly add up. The work here switches to use the wall time since the first packet was sent as the reference which is compared to the PCAP packet timestamp relative to the first packet. In this way there are no errors and clock drift is avoided. As a result tcpreplay can now be used to play back very time sensitive captures such as video streams with PCR.
Bug #634 fix gcc 8.3.0 complier warnings
Fix UNUSED Macro declaration
Also did some fixes to Juniper Ethernet protocols to fix some bugs and support various types of Juniper Ethernet protocol types. Used Wireshark sources to figure out all the different packet types that Juniper uses. Unable to test all types because of lack of JNPER DLT pcaps. Also applied a fix for DLT_RAW to prevent similar issues.
Bug #616 Add checks for datalen for DLT_JUNIPER_ETHER
Bug #616 Bug_#617_CVE-2020-24265 includes updates that fixes this issue. See PR #637 for details.
Bug #617 CVE-2020-24266 fix tcpprep get_l2len()
…t_packet Bug #619 buffer overflow get_next_packet()
Add safety and failure reporting for packet captures with caplen too small.
…_PF_INET6 Bug #624 DLT_NULL/DLT_LOOP support for multi-platform PF_INET6 values
Centos 7 uses automake version 1.13.4 wich is unable to generate proper [include directives](https://www.gnu.org/software/automake/manual/html_node/Include.html). To build on Cento 7 use [release version](https://github.com/appneta/tcpreplay/releases/latest).
…pile Bug #553 Centos 7 disable maintainer compile
Change calculation after high packet sent count. The updated calculation will not work well for something like `--pps=0.1` but that would take many years to overflow, even on 32-bit machines.
Bug #629 Compensate for overflow on high pps tests
fixed simple typo, to short -> too short
This issue became more evident with #630. First file has proper deltas, second file sends with no delay. Tested with 2 ping.pcap files and obverved proper delays.
…ile_works Bug #472 Reset timestamps for multiplier between files
Code says `jnpr_eth`, but documentation says `jnpr_ether`. Signed-off-by: Vincent Bernat <vincent@bernat.ch>
clean up string manipulation in error exit
tcprewrite: fix DLT name for DLT_C_JNPR_ETHER in documentation
Bug #658 fix libopts warnings
remove duplicate #include "lib/strlcpy.h"
replace memset followed by strncpy with strlcpy
add myself to CREDIT
Bug #662 ASAN detected memory leaks
…dlt_conversion Bug #582 calculate L2 length based on exporter DLT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.