Bug #557 Attempt to correct corrupt packets #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If packet caplen > packet len, update caplen to equal len. Although this appears to be impossible if trace was generated from a reliable source (i.e. libpcap), there appears to be enough pressure from the community to allow these invalid packets to be sent. IMHO, I think that if a pcap is invalid, tcpreplay should fail. But it appears that this is the behavior desired by users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If packet caplen > packet len, update caplen to equal len.
Although this appears to be impossible if trace was generated from
a reliable source (i.e. libpcap), there appears to be enough pressure
from the community to allow these invalid packets to be sent.
IMHO, I think that if a pcap is invalid, tcpreplay should fail. But it
appears that this is the behavior desired by users.