Avoid non-blocking behaviour when using STDIN #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While on BSD systems, tcprewrite likely sets `O_NDELAY` which is proper for most posix systems as this is the newer flag and they likely treat both similarly. However BSD and unix derivatives should likely utilize `FIONBIO` due to known issues with reading from tty with a 0 byte read returning -1 opposed to 0. Reference comment 1: https://stackoverflow.com/questions/1150635/unix-nonblocking-i-o-o-nonblock-vs-fionbio on behalf of Cisco Talos
|
Thanks for the PR. I'll review and schedule for next release. |
fklassen
added a commit
that referenced
this pull request
Jan 21, 2018
fklassen
added a commit
that referenced
this pull request
Jan 21, 2018
fklassen
added a commit
that referenced
this pull request
Jan 22, 2018
fklassen
added a commit
that referenced
this pull request
Jan 22, 2018
Enhancement #416 non blocking stdin
fklassen
added a commit
that referenced
this pull request
Oct 19, 2018
* Enhancement_#493_codacy_fixes: (26 commits) Enhancement #493 - fixes for Codacy identified issues Bug #486 Enforce max snaplen rather than doing realloc Bug #486 CVE-2018-17974 realloc memory if packet size increases Bug #484 CVE-2018-17582 Check for corrupt PCAP files 4.3 - revert travis updates from merge Remove dead code resolve possible null pointer dereference travis-ci: add autogen package Bug #461 build warnings (#462) #412 fix gcc 6.3 compiler warning #421 fix ms to ns conversion Bug #423 remove commented code Bug #423 Remove limit for tcpprep -S Bug #398 Rewrite of tcpdump.c (#457) Bug #402 memset dlt radiotap get 80211 (#454) #404 fix check_list return values (#453) #406 fix zero-length IP headers #416 apply STDIN restore to all programs #416 fix compile issue introduced by downstream PR #416 update CHANGELOG [ci skip] ...
This was referenced Oct 21, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While on BSD systems, tcprewrite likely sets
O_NDELAYwhich isproper for most posix systems as this is the newer flag and they
likely treat both similarly. However BSD and unix derivatives should
likely utilize
FIONBIOdue to known issues with reading from ttywith a 0 byte read returning -1 opposed to 0.
Reference comment 1: https://stackoverflow.com/questions/1150635/unix-nonblocking-i-o-o-nonblock-vs-fionbio
on behalf of Cisco Talos