Merge pull request #802 from appneta/Bug_#793_ip6_unicast_flood

PR #793 ip6 unicast flood
appneta · Jun 10, 2023 · 38c46f7 · 38c46f7
2 parents 128ecaf + e3e18e6
commit 38c46f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/docs/CHANGELOG b/docs/CHANGELOG
@@ -1,4 +1,5 @@
 06/04/2023 Version 4.4.4-beta1
+    - tcpreplay-edit: prevent L2 flooding of ipv6 unicast packets (#793)
     - CVE-2023-27786 bugs caused by strtok_r (#782 #784 #785 #786 #787 #788)
     - CVE-2023-27783 reachable assert in tcpedit_dlt_cleanup (#780)
     - add CI - C/C++ Linter and CodeQL (#773)

diff --git a/docs/CREDIT b/docs/CREDIT
@@ -109,4 +109,7 @@ Halver <GitHub @Halver>
     - specify directories as files
 
 Florian Weimer <GitHub @fweimer-rh>
-    - Avoid implicit int in configure.ac
+    - Avoid implicit int in configure.ac
+
+David Guti <GitHub @david-guti>
+    - prevent L2 flooding of ipv6 unicast packets for tcpreplay-edit
diff --git a/src/tcpedit/plugins/dlt_en10mb/en10mb.c b/src/tcpedit/plugins/dlt_en10mb/en10mb.c
@@ -780,7 +780,7 @@ static void
 dlt_en10mb_ipv6_multicast_mac_update(const struct tcpr_in6_addr *ip6, uint8_t mac[])
 {
     /* only modify multicast packets */
-    if (ip6->tcpr_s6_addr[0] == 0xff)
+    if (ip6->tcpr_s6_addr[0] != 0xff)
         return;
 
     mac[0] = 0x33;