Merge pull request #744 from appneta/Bug_#735_heap-overflow_get_c

Bug #735 heap-overflow in get_l2len_protocol
appneta · Aug 7, 2022 · 34a5fc1 · 34a5fc1
2 parents dc2cc31 + 6a84081
commit 34a5fc1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/CHANGELOG b/docs/CHANGELOG
@@ -1,4 +1,5 @@
 08/02/2022 Version 4.4.2 Beta 1
+    - heap-overflow in get_l2len_protocol (#735)
     - replaying on a loopback interface is broken (#732)
     - replay edit with both --loop and --preload_pcap options (#729)
     - test suite bus error on armhf (#725)

diff --git a/src/common/get.c b/src/common/get.c
@@ -337,7 +337,7 @@ int get_l2len_protocol(const u_char *pktdata,
                            vlan_offset))
             return -1;
 
-        if (datalen < l2_net_off)
+        if (datalen <= l2_net_off)
             return -1;
 
         *l2len = l2_net_off;