deps: update to dag-pb version which allocates new slices #154
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5762af7 to
ace2df4
Compare
Codecov ReportBase: 20.84% // Head: 20.84% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 20.84% 20.84%
=======================================
Files 16 16
Lines 2341 2341
=======================================
Hits 488 488
Misses 1823 1823
Partials 30 30 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kylehuntsman
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ipld/go-codec-dagpb#57
Ref: #142 (comment)
#150 didn't seem to have the impact I hoped, but I want to try this to see if it does--if this doesn't have an impact then I'm not looking in the right place.
Note this is an untagged (and unmerged) version of go-codec-dagpb; I'll revert this if it has no impact and if it does then look to merging and tagging that version (although there's some discussion to be had there about whether it's the right place to do this).