Provide way to set cluster consistency #8
Conversation
rdar://102086631
| @@ -90,7 +90,7 @@ public class CassandraClient: CassandraSession { | |||
| /// - logger: If `nil`, the client's default `Logger` is used. | |||
| /// | |||
| /// - Returns: The resulting ``Rows``. | |||
| public func execute(statement: Statement, on eventLoop: EventLoop?, logger: Logger? = nil) -> EventLoopFuture<Rows> { | |||
| public func execute(statement: Statement, on eventLoop: EventLoop?, logger: Logger? = .none) -> EventLoopFuture<Rows> { | |||
There was a problem hiding this comment.
completely subjective but IMO .none is less idiomatic than nil
|
|
||
| public extension CassandraClient { | ||
| /// Consistency levels | ||
| enum Consistency { |
There was a problem hiding this comment.
This should be public.
I'm also wondering if this should be a struct backed by an internal enum with a public static let per-case: users shouldn't need to switch over it and new "cases" can be added without breaking API.
There was a problem hiding this comment.
Relatedly: CassandraClient.Configuration should also be public (all the methods and functions are but the type isn't)
There was a problem hiding this comment.
Oh my mistake: both are defined in public extensions.
There was a problem hiding this comment.
Updating SwiftFormat rule to prevent this sort of confusion. Amended a245c86
There was a problem hiding this comment.
I'm also wondering if this should be a struct backed by an internal enum with a public static let per-case
I understand your point, but I doubt users would switch over this particular enum.
rdar://102086631