Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort job with multiple files when backend fails #5413

Closed
wants to merge 1 commit into from
Closed

Abort job with multiple files when backend fails #5413

wants to merge 1 commit into from

Conversation

zdohnal
Copy link
Contributor

@zdohnal zdohnal commented Oct 17, 2018

Hi,

there is the first shot, which gets multiple files job aborted when backend suddenly lost connection during data transfer as I wrote in email. I am lost in making such job retry - I think a recovery for retry is rather complicated - checking which file didn't print correctly and probably creating new job for the unfinished business.
This pull request is connected to issue #5359 , is it a right way to go?

@zdohnal
Copy link
Contributor Author

zdohnal commented Oct 17, 2018

I ran basic tests from project and results are good. There are expected failures (according test) and one unexpected, but without connection to the issue (4.4-subscription-ops.test failed with server-error-internal-error (Invalid group tag.))

@michaelrsweet
Copy link
Collaborator

I pushed a slightly different fix, and all tests appear to pass.

[master 72a2134] Fix stuck multi-file jobs (Issue #5359, Issue #5413)

[branch-2.2 e7e33bf] Fix stuck multi-file jobs (Issue #5359, Issue #5413)

@zdohnal
Copy link
Contributor Author

zdohnal commented Nov 7, 2018

Thank you, Mike! I'll test it tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants