Fixing several issues reported by coverity scan #5375
Conversation
|
All issues in report which sent you were labeled as important, so there are other issues, but coverity doesn't count them as important. |
| @@ -3624,4 +3624,7 @@ update_reasons(ipp_attribute_t *attr, /* I - printer-state-reasons or NULL */ | |||
| fprintf(stderr, "%s\n", add); | |||
| else if (rem[0]) | |||
| fprintf(stderr, "%s\n", rem); | |||
|
|
|||
| if (new_reasons != NULL) | |||
| cupsArrayDelete(new_reasons); | |||
There was a problem hiding this comment.
OK, we should just initialize new_reasons to NULL up top and then call cupsArrayDelete unconditionally (it handles NULLs just fine.)
| @@ -3916,6 +3916,7 @@ http_create( | |||
| { | |||
| _cupsSetError(IPP_STATUS_ERROR_INTERNAL, strerror(errno), 0); | |||
| httpAddrFreeList(addrlist); | |||
| httpAddrFreeList(myaddrlist); | |||
There was a problem hiding this comment.
I need to look at this more closely; my gut says we should just be freeing myaddlist and not addrlist (since, if supplied, we copy addrlist to myaddrlist...)
| @@ -1076,7 +1076,7 @@ cupsRasterWriteHeader( | |||
|
|
|||
| void *dst = fh.cupsReal; /* Bypass bogus compiler warning */ | |||
| void *src = r->header.cupsReal; | |||
| memcpy(dst, src, sizeof(fh.cupsReal) + sizeof(fh.cupsString)); | |||
| memcpy(dst, src, sizeof(fh.cupsReal)); | |||
There was a problem hiding this comment.
This is wrong. We need to copy everything in cupsReal and cupsString - cupsString follows cupsReal in the structure so this is valid.
| */ | ||
| free(device_id_re); | ||
| free(make_and_model_re); | ||
|
|
There was a problem hiding this comment.
We don't care about this because main() calls list_ppds() and then returns, freeing all memory used by the program. Perhaps I should have it not return and instead exit().
|
I apologize for late reply, I was on vacation last week - I'll run it through coverity scan and I'll check with you about results. |
|
I checked the commit with coverity - the results are okay, no new important reports. Thank you! |
Here is cleaner commit...