Fix validation rejecting all NAME and TEXT attrs #5330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the UTF-8 validation loop finishes successfully, `*ptr` points at the `'\0'` at the end of the string. The code misinterpreted this as a control character (`*ptr < ' '`) and failed the validation. Fixes apple#5325
Closed
michaelrsweet
added a commit
that referenced
this pull request
Jun 11, 2018
michaelrsweet
added a commit
that referenced
this pull request
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the UTF-8 validation loop finishes successfully,
*ptrpoints atthe
'\0'at the end of the string. The code misinterpreted this as acontrol character (
*ptr < ' ') and failed the validation.Fixes #5325