mailto: Wait for server opening message #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subset of all mailserver configurations reject SMTP sessions where the client sends anything before the server sent its opening message. This is the case with Exim on Ubuntu Artful, for example: SMTP protocol synchronization error (input sent without waiting for greeting) Not waiting for the opening message is a violation of the session initiation described in RFC5321 (section 3.1). Update the mailto notifier to wait for a non-error status code from the server before proceeding to start the mail transaction.
|
OK, so we'll definitely pick this up, but I'm thinking I want a wait timeout in there in case we are talking to a non-conforming SMTP server... |
|
Looking at the code we are not doing timeouts for the other cupsFileGets calls, so we'll go with it... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subset of all mailserver configurations reject SMTP sessions where the
client sends anything before the server sent its opening message. This
is the case with Exim on Ubuntu Artful, for example:
Not waiting for the opening message is a violation of the session
initiation described in RFC5321 (section 3.1). Update the mailto
notifier to wait for a non-error status code from the server before
proceeding to start the mail transaction.