cups + ipptool + duplicate attribute values

[goudal-emmk]

Cups version 2.1.3
When requesting completed-jobs with ipptool, I've got an error « duplicate attribute ». Which prevent the tabular output to get printed.
From the xml file I have :

ipp://xxxxx:631/jobs/34335
job-originating-user-name
username
job-originating-user-name
username

I have found that this bug was referenced as #4275 and closed in 2016... but still there.

f.g.

[michaelrsweet]

Well, the job history files will always have the duplicate attributes, which is the issue that is being reported by the tool - it has no way to know which value you want reported, and the duplicate attributes are an error at the IPP protocol level.

[goudal-emmk]

Well... I'm not sure I understand what do you mean : only ONE job had a duplicate value.
And if so, why not displaying the result in tabular output - or at least put an error message ? As the XML file got all the values.
And if it is always the case (not for the present moment on my printers) why the error is not correctly treaded ?

[michaelrsweet]

We can consider changing the current behavior, but what should what behavior be?

If we display a table of values, do we show an error message about the duplicate and then put the first value in the table, or do we display a placeholder "ERROR" string for any duplicates?

[goudal-emmk]

From my sysadmin point of view :

• 1. cups is sending duplicate value ? Is it a bug ? Is it something that can be changed ?
• 2. ipptool get 2 duplicate attributes : on my experience the values were the same.
• 3. ipptool is able to detect the error and to give correct information in the plist output.
     What I would like is of course that duplicate values don't occurs. But if cups can't send correct data :
• in tabular or cvs display, when you have a duplicate value, the only message printed is « ok-successful », that is obviously incorrect as an error has been found. At least an error message should be displayed, and a correct return value.
• best : if the duplicated attributes have the same value, ignore the duplicate.
• if the duplicated attributes have a different values, I think that displaying both could be nice, but maybe an error tag would be ok.

[goudal-emmk]

Furthermore from what I have seen in debugging, there is a strange behaviour (but maybe I'm wrong) :
in the print_line function you search for attributes following the displayed array values.
But I have seen that the attribute list of the job is not always in the same order of the displayed array. As this function never goes back in the attributes list of the current job, some attributes may lack in the final result.... or maybe I have missed a point.

[michaelrsweet]

[master 884db541c] The ipptool program no longer checks for duplicate attributes when running in list or CSV mode (Issue #5278)

[branch-2.2 d2e90eb] The ipptool program no longer checks for duplicate attributes when running in list or CSV mode (Issue #5278)