Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPP Everywhere: Improve media support #5167

Closed
michaelrsweet opened this issue Nov 9, 2017 · 3 comments
Closed

IPP Everywhere: Improve media support #5167

michaelrsweet opened this issue Nov 9, 2017 · 3 comments
Assignees
@michaelrsweet
Labels
enhancement New feature or request priority-high
Milestone
CUPS 2.3.x

Comments

@michaelrsweet
Copy link
Collaborator

This issue was raised on the cups-devel mailing list...

Currently the destination API and PPD generator does not support borderless sizes, making it impossible to do borderless printing. We need to:

a. Update _ppdCreateFromIPP to use media-col-database to get the margins and include full-bleed sizes as applicable.
b. Update cups_create_cached in dest-options.c to generate matching media size names.
c. Update cupsLocalizeDestMedia to support full-bleed size names.

When updating cups_create_cached, we should also thin the list to remove duplicates as well.
@michaelrsweet michaelrsweet added the enhancement New feature or request label Nov 9, 2017
@michaelrsweet michaelrsweet self-assigned this Nov 9, 2017
@michaelrsweet michaelrsweet added this to the CUPS 2.3.x Release milestone Nov 9, 2017
@michaelrsweet michaelrsweet changed the title IPP Everywhere: Support borderless sizes IPP Everywhere: Improve media support Nov 9, 2017
@michaelrsweet
Copy link
Collaborator Author

Also make sure developers can add media-source and media-type options to select the corresponding size and source.

michaelrsweet added a commit that referenced this issue Nov 29, 2017
@michaelrsweet
First part of better media support (Issue #5167)
982be45 
cups/dest-localization.c:
- Fix localization of borderless/non-borderless media.

cups/dest-options:
- Add support for borderless size names (still needs work)

cups/ppd-cache.c:
- Fix PageSize support in PPD generator - borderless media and custom page sizes.

cups/testppd.c:
- Need to request media-col-database for PPD generator.
michaelrsweet added a commit that referenced this issue Nov 29, 2017
@michaelrsweet
Finish up media improvements (Issue #5167)
71dc43a 
cups/cups.h:
- Add cupsAddDestMediaOptions API.

cups/dest-localization.c:
- Fix cupsLocalizeDestMedia API.

cups/dest-options.c:
- Synthesize a media-key value when one is not provided by the printer (!?!?)
- Add cupsAddDestMediaOptions API.
@michaelrsweet
Copy link
Collaborator Author

Most of the changes are in, but still need to add some of the common vendor-specific media types...

michaelrsweet added a commit that referenced this issue Nov 30, 2017
@michaelrsweet
Last of the media improvements (Issue #5167)
84de5e9 
cups/dest-localization.c:
- Use "other tray" and "other media" for unknown media sources and types.

cups/dest-options.c:
- media-key is king for size matching.
- Synthesize a media-key value using the size name unless we can't get one.

cups/language-private.h:
- Add _CUPS_MESSAGE_PO constant.

cups/pwg-media.c:
- Allow PWG names with a trailing "_foo" qualifier (so media-key still works
  if an application just adds the _cups_size_t.media value as the "media"
  option.

locale/*.{po,pot,strings}:
- Update localization strings.

locale/cups.footer:
- Add common HP and Canon media types.

locale/checkpo.c:
- Fix \ validation.
@michaelrsweet
Copy link
Collaborator Author

All done...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
enhancement New feature or request priority-high
Projects
None yet
Milestone
CUPS 2.3.x
Development

No branches or pull requests
1 participant
@michaelrsweet