Skip to content

Commit

Permalink
Fix potential excess logging from the scheduler when removing job files
Browse files Browse the repository at this point in the history
(Issue #5597)

(may be Debian-specific, as I was unable to duplicate - the extra check is in
place in case file_time is reset)
  • Loading branch information
michaelrsweet committed Jul 16, 2019
1 parent 614efb7 commit 6647894
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ Changes in CUPS v2.3.0
- Eliminated some new GCC compiler warnings (Issue #5591)
- Removed dead code from the scheduler (Issue #5593)
- "make" failed with GZIP options (Issue #5595)
- Fixed potential excess logging from the scheduler when removing job files
(Issue #5597)
- Fixed a NULL pointer dereference bug in `httpGetSubField2` (Issue #5598)
- The scheduler no longer provides a default value for the description
(Issue #5603)
Expand Down
2 changes: 1 addition & 1 deletion scheduler/job.c
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ cupsdCleanJobs(void)
cupsdLogJob(job, CUPSD_LOG_DEBUG, "Removing from history.");
cupsdDeleteJob(job, CUPSD_JOB_PURGE);
}
else if (job->file_time && job->file_time <= curtime)
else if (job->file_time && job->file_time <= curtime && job->num_files > 0)
{
cupsdLogJob(job, CUPSD_LOG_DEBUG, "Removing document files.");
remove_job_files(job);
Expand Down

0 comments on commit 6647894

Please sign in to comment.