fix: Skip chromedriver proxy suspend if the proxy is not initialized …

…yet (#754)
appium · Mar 20, 2024 · a6d9146 · a6d9146
1 parent f749f93
commit a6d9146
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/lib/commands/app-management.js b/lib/commands/app-management.js
@@ -23,7 +23,7 @@ export async function mobileInstallMultipleApks(opts) {
 /**
  * Puts the app to background and waits the given number of seconds Then restores the app
  * if necessary. The call is blocking.
- * @this {AndroidUiautomator2Driver}=
+ * @this {AndroidUiautomator2Driver}
  * @param {import('./types').BackgroundAppOptions} [opts={}]
  * @returns {Promise<void>}
  */

diff --git a/lib/commands/misc.js b/lib/commands/misc.js
@@ -74,6 +74,10 @@ export async function openNotifications() {
  * @returns {void}
  */
 export function suspendChromedriverProxy() {
+  if (!this.uiautomator2?.proxyReqRes || !this.uiautomator2?.proxyCommand) {
+    return;
+  }
+
   this.chromedriver = undefined;
   this.proxyReqRes = this.uiautomator2.proxyReqRes.bind(
     this.uiautomator2

diff --git a/lib/driver.ts b/lib/driver.ts
@@ -1059,7 +1059,7 @@ class AndroidUiautomator2Driver
   setOrientation = setOrientation;
   getClipboard = getClipboard;
   openNotifications = openNotifications;
-  suspendChromedriverProxy = suspendChromedriverProxy;
+  suspendChromedriverProxy = suspendChromedriverProxy as any;
   mobileGetDeviceInfo = mobileGetDeviceInfo;
 
   setUrl = setUrl;