This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Add idb check, remove ptyhon version check for dump #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KazuCocoa
commented
May 26, 2019
- Remove Python 2 check since we no longer need it Remove the obsolete --enable-heapdump command line arg appium#12609
- Remove Python 2.x check #72
- Replace fbsctl with idb
- Replace the obsolete fbsimctl with idb appium-ios-simulator#224
| @@ -195,55 +195,4 @@ describe('general', function () { | |||
| equal('mjpeg-consumer module is required to use MJPEG-over-HTTP features. Please install it with `npm i -g mjpeg-consumer`.'); | |||
| }); | |||
| })); | |||
|
|
|||
| describe('OptionalPythonVersionCheck', withMocks({tp, utils}, (mocks) => { | |||
There was a problem hiding this comment.
actually idb requires minimum Python 3.6 to be installed
There was a problem hiding this comment.
yeah, good point.
In this case, it was enough if idb command existed as this doctor, I thought.
If a user has no idb (or python 3.6), we'll guide them to https://github.com/appium/appium-idb . Then the user can see the python requirement. If the user already has idb, we can expect the user has python 3 env.
lib/ios.js
Outdated
| } | ||
|
|
||
| return nokOptional('fbsimctl cannot be found'); | ||
| return nokOptional('idb and/or idb_companion are not installed'); |
There was a problem hiding this comment.
I'd rather show separate error messages for idb and its companion
| return nokOptional('fbsimctl cannot be found'); | ||
| if (!fbIdbPath && fbCompanionIdbPath) { | ||
| return nokOptional('idb is not installed'); | ||
| } else if (fbIdbPath && !fbCompanionIdbPath) { |
mykola-mokhnach
approved these changes
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.